Trim away netframework targets in source-build #5091
Conversation
ghost
added
the
| @@ -23,7 +23,7 @@ | |||
| <TargetFrameworksExeForSigning Condition=" '$(IsXPlat)' == 'true' ">$(NETCoreTargetFramework);netcoreapp5.0</TargetFrameworksExeForSigning> | |||
| <TargetFrameworksExeForSigning Condition="'$(DotNetBuildFromSource)' == 'true'">$(TargetFrameworksExe);net7.0</TargetFrameworksExeForSigning> | |||
| <TargetFrameworksLibrary>$(NETFXTargetFramework);$(NetStandardVersion)</TargetFrameworksLibrary> | |||
| <TargetFrameworksLibrary Condition="'$(DotNetBuildFromSource)' == 'true'">$(NETCoreTargetFramework);$(NETFXTargetFramework);$(NetStandardVersion)</TargetFrameworksLibrary> | |||
There was a problem hiding this comment.
I find this change interesting.
This used to be something that was explicitly added for source build before, but now it's getting removed?
b5f0bb7
There was a problem hiding this comment.
I think the issue was that the netfx TFMs were referenced downstream in SDK. We're eliminating the use of the netfx TFMs in Linux source-build, so this should no longer be necessary.
There was a problem hiding this comment.
Thanks @nkolev92 - yeah, that was probably needed for other repos that consumed nuget.client artifacts. We are removing all targeting of .NET FX from source-build now.
There was a problem hiding this comment.
Failing CI leg Apex Tests on Windows is not caused by my change, which is source-build (Linux) specific.
Bug
Fixes: NuGet/Home#12074
Regression? No
Description
This is part of the source-build work to enable trimming of net4* targets. Parent repos (
installerandsdk) have been updated, so the next step is to update dependencies, likenuget.client.Here's how this is consumed: dotnet/arcade#12785
Top-level tracking issue: dotnet/source-build#3014
This essentially just avoids building net4* TFMs when building Linux source build.
Tests
Infrastructure change specific for source-build.
Tested in full local source-build.